Skip to content

Cleaning up old cruft #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Cleaning up old cruft #5068

wants to merge 3 commits into from

Conversation

coolaj86
Copy link
Contributor

@coolaj86 coolaj86 commented Oct 11, 2018 •
edited
Loading

Re: #5066

  • Remove dangling reference to gorilla/context
  • Remove gorilla from vendor
  • Remove gorilla from Gopkg.*
  • Remove old gogs script
  • Remove old mysql script

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 11, 2018
@coolaj86
Copy link
Contributor Author

coolaj86 commented Oct 11, 2018 •
edited
Loading

@lafriks Was the gorilla/context added for xormstore and/or goth?

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2018
@coolaj86
Copy link
Contributor Author

@bkcsoft this isn't ready for lgtm - it's passing test due to gorilla being used by xormstore (and goth?). The thing I removed may actually be a necessary hack to prevent memory leaks in the oauth2 flow. Awaiting feedback.

@adelowo
Copy link
Member

adelowo commented Oct 11, 2018

@bkcsoft this isn't ready for lgtm

I think the lgtm label thing is automated

techknowlogick
techknowlogick reviewed Oct 29, 2018
View reviewed changes
cmd/web.go
case setting.FCGI:
listener, err := net.Listen("tcp", listenAddr)
if err != nil {
log.Fatal(4, "Failed to bind %s", listenAddr, err)
}
defer listener.Close()
err = fcgi.Serve(listener, context2.ClearHandler(m))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context2.ClearHandler() is used for to prevent memory leaks. I think it may still be needed.

@stale
Copy link

stale bot commented Jan 5, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 5, 2019
@stale
Copy link

stale bot commented Jan 19, 2019

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this Jan 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

Assignees
No one assigned
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coolaj86 @adelowo @techknowlogick @bkcsoft